kvm: fix disk controller for secure boot vm #10213

shwstppr · 2025-01-20T10:45:56Z

Description

Fixes #9460

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#9460 Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-01-20T10:48:02Z

This would fix the issue but not sure if could cause the issue of disks not being identified when virtio drivers are not installed. Maybe we can add some documentation. ping @pavanaravapalli, if you've any advise

@blueorangutan package

blueorangutan · 2025-01-20T10:50:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-01-20T11:33:20Z

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 15.47%. Comparing base (422264f) to head (9406e6e).
⚠️ Report is 88 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ervisor/kvm/resource/LibvirtComputingResource.java	90.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10213      +/-   ##
============================================
+ Coverage     15.16%   15.47%   +0.30%     
- Complexity    11332    11735     +403     
============================================
  Files          5412     5416       +4     
  Lines        475033   493478   +18445     
  Branches      57963    66305    +8342     
============================================
+ Hits          72048    76343    +4295     
- Misses       394930   408648   +13718     
- Partials       8055     8487     +432

Flag	Coverage Δ
uitests	`4.38% <ø> (+0.09%)`	⬆️
unittests	`16.20% <90.00%> (+0.31%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-01-20T11:49:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12127

weizhouapache · 2025-01-20T12:31:25Z

...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

-                        } else {
-                            disk.defFileBasedDisk(physicalDisk.getPath(), devId, diskBusType, DiskDef.DiskFmtType.QCOW2);
-                        }
+                        disk.defFileBasedDisk(physicalDisk.getPath(), devId, diskBusType, DiskDef.DiskFmtType.QCOW2);


for DATADISK, should it use diskBusTypeData instead ?

...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

A VM or template detail can be added with key `win.skip.force.disk.controller` and value `true` to allow skipping forcing DATA disk controller for the VM. Signed-off-by: Abhishek Kumar <[email protected]>

github-actions · 2025-04-24T08:07:03Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…diskcontroller

shwstppr · 2025-04-24T08:26:18Z

@pavanaravapalli @weizhouapache cc @rajujith @vladimirpetrov I've made the behaviour configurable using VM (or template) detail. User/operator can add a VM/template detail - win.skip.force.disk.controller = true to make KVM plugin not force SATA controller for Windows VM with secured boot

@blueorangutan package

blueorangutan · 2025-04-24T08:28:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-24T09:44:13Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13161

weizhouapache · 2025-04-24T09:49:53Z

@blueorangutan package

blueorangutan · 2025-04-24T09:52:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-24T11:15:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13164

shwstppr · 2025-05-12T12:35:01Z

@blueorangutan package

blueorangutan · 2025-05-12T12:36:05Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-12T13:45:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13345

shwstppr · 2025-08-24T13:55:12Z

@blueorangutan package

blueorangutan · 2025-08-24T13:56:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-24T14:52:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14717

shwstppr · 2025-09-07T05:16:15Z

@blueorangutan package

blueorangutan · 2025-09-07T05:18:06Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-07T06:22:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14884

DaanHoogland · 2025-09-16T13:51:09Z

@blueorangutan test

blueorangutan · 2025-09-16T13:52:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-17T03:58:49Z

[SF] Trillian test result (tid-14360)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 47868 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10213-t14360-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

pavanaravapalli · 2025-09-19T08:30:07Z

...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

-                        }
-                    }
-
+                    defineDiskForDefaultPoolType(disk, volume, isWindowsTemplate, isUefiEnabled, isSecureBoot,


@shwstppr If a user forces the disk type with this template flag, will Secure Boot still work?

@pavanaravapalli probably not for all guest OSes, but should work for newer ones, as #9460 reports VM works fine with virtio. Also, as this is optional, it is up to the operator to check and use

@shwstppr Thanks for the response. We should mention potential UEFI workflow issues in the flag description since guest OS support varies.

DaanHoogland

clgtm

weizhouapache · 2025-09-22T15:00:21Z

api/src/main/java/com/cloud/vm/VmDetailConstants.java

    String NIC_PACKED_VIRTQUEUES_ENABLED = "nic.packed.virtqueues.enabled";

+    // KVM specific, disk controllers
+    String KVM_WIN_SKIP_FORCE_DISK_CONTROLLER = "win.skip.force.disk.controller";


In my opinion, the root disk and data disk controller should not be changed when vm is stopped and started, in regardless of the vm settings

@weizhouapache In my test they are not really changed. Even at the deployment time, Windows VM with secure boot was always getting sata while other (Linux, etc) VMs were getting virtio

shwstppr · 2025-09-26T05:25:17Z

I'm closing this for now, as we don't have a consensus and a proper solution

shwstppr · 2025-09-29T10:43:28Z

Recreated here, #11750

kvm: fix disk controller for secure boot vm

edd537f

Fixes apache#9460 Signed-off-by: Abhishek Kumar <[email protected]>

boring-cyborg bot added the component:kvm label Jan 20, 2025

weizhouapache reviewed Jan 20, 2025

View reviewed changes

pavanaravapalli reviewed Jan 20, 2025

View reviewed changes

...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java Outdated Show resolved Hide resolved

DaanHoogland linked an issue Mar 5, 2025 that may be closed by this pull request

RootDiskController setting not Honored throughout Instance lifecycle #9460

Open

kvm: allow skip forcing disk controller for Win VM with secure boot

d10d510

A VM or template detail can be added with key `win.skip.force.disk.controller` and value `true` to allow skipping forcing DATA disk controller for the VM. Signed-off-by: Abhishek Kumar <[email protected]>

boring-cyborg bot added the component:api label Apr 24, 2025

github-actions bot added the status:has-conflicts label Apr 24, 2025

Merge remote-tracking branch 'apache/4.19' into fix-kvm-securebootvm-…

9406e6e

…diskcontroller

github-actions bot removed the status:has-conflicts label Apr 24, 2025

shwstppr closed this May 16, 2025

shwstppr reopened this Aug 24, 2025

shwstppr marked this pull request as ready for review September 2, 2025 06:59

weizhouapache added this to the 4.20.2 milestone Sep 16, 2025

DaanHoogland assigned abh1sar Sep 19, 2025

pavanaravapalli reviewed Sep 19, 2025

View reviewed changes

DaanHoogland approved these changes Sep 19, 2025

View reviewed changes

DaanHoogland added the status:needs-testing label Sep 19, 2025

weizhouapache reviewed Sep 22, 2025

View reviewed changes

abh1sar removed their assignment Sep 22, 2025

shwstppr closed this Sep 26, 2025

kvm: fix disk controller for secure boot vm #10213

kvm: fix disk controller for secure boot vm #10213

Uh oh!

Conversation

shwstppr commented Jan 20, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Jan 20, 2025

Uh oh!

codecov bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jan 20, 2025

Uh oh!

weizhouapache Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2025

Uh oh!

shwstppr commented Apr 24, 2025

Uh oh!

blueorangutan commented Apr 24, 2025

Uh oh!

blueorangutan commented Apr 24, 2025

Uh oh!

weizhouapache commented Apr 24, 2025

Uh oh!

blueorangutan commented Apr 24, 2025

Uh oh!

blueorangutan commented Apr 24, 2025

Uh oh!

shwstppr commented May 12, 2025

Uh oh!

blueorangutan commented May 12, 2025

Uh oh!

blueorangutan commented May 12, 2025

Uh oh!

shwstppr commented Aug 24, 2025

Uh oh!

blueorangutan commented Aug 24, 2025

Uh oh!

blueorangutan commented Aug 24, 2025

Uh oh!

shwstppr commented Sep 7, 2025

Uh oh!

blueorangutan commented Sep 7, 2025

Uh oh!

blueorangutan commented Sep 7, 2025

Uh oh!

DaanHoogland commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

pavanaravapalli Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

pavanaravapalli Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache Sep 22, 2025

shwstppr commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading